RFR: 7903156: remove jopt-simple dependency from jextract [v4]
Athijegannathan Sundararajan
sundar at openjdk.java.net
Tue Apr 12 14:13:15 UTC 2022
On Tue, 12 Apr 2022 12:58:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> -C "-D FORCE_OPENBLAS_COMPLEX_STRUCT" does not work. For now changing it to -C-DFORCE_OPENBLAS_COMPLEX_STRUCT
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 218:
>
>> 216: }
>> 217:
>> 218: private static final class OptionParser {
>
> I suggest putting this (and related classes) in a separate file
will revisit
> src/main/java/org/openjdk/jextract/JextractTool.java line 245:
>
>> 243: if (spec == null) {
>> 244: // check if we have usage like -C<clang_option> such as -C-xc++
>> 245: int idx = arg.indexOf('-', 1);
>
> This logic seems flawed for `--` arguments. E.g. `--source-I /usr/local/include`.
changed with another commit
> src/main/java/org/openjdk/jextract/JextractTool.java line 255:
>
>> 253: }
>> 254: // handle argument associated with the current option, if any
>> 255: List<String> values;
>
> Why a list? Isn't there only one possible value?
options like "capital I", "small l" can be repeated. hence list.
-------------
PR: https://git.openjdk.java.net/jextract/pull/19
More information about the jextract-dev
mailing list