RFR: 7903156: remove jopt-simple dependency from jextract [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Apr 12 14:29:13 UTC 2022


On Tue, 12 Apr 2022 13:34:33 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> removed jopt-simple dependency as well as moditect grade plugin dependency. Piggybacking build.gradle change to enforce 'jtreg_home' check in jtreg task's doFirst block.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   handling options such as -lclang.

src/main/java/org/openjdk/jextract/JextractTool.java line 244:

> 242:                    String argValue = null;
> 243:                    if (spec == null) {
> 244:                        // check for single char option specifier followed

few suggestions:
* add a property to the option spec that says "I'm ok with no spaces"
* add a check in this logic which, before blindly splitting the argument string, it checks that it's one of the weird option specs with no space and required value
* it would be nice if, instead of hardwiring the 2, we could do something else, so that we can support even options with no spaces, but whose name is longer than 1 char

-------------

PR: https://git.openjdk.java.net/jextract/pull/19


More information about the jextract-dev mailing list