RFR: gradle buildscript improvements

[Athijegannathan Sundararajan]

On Wed, 27 Apr 2022 04:21:34 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Some improvements based on suggestions I made in an email [1]. Since then, the buildscript has a evolved quite a bit so some of my suggestions became obsolete or easier. This PR generally implements suggestions 2 and 3 from my email.
>> 
>> Use Gradle incremental builds and up to date checks:
>> - The `createJextractImage` and `createRuntimeImageForTest` tasks now use Gradle task input and ouputs to enable up to date checks.
>> - The cmake tasks could theoretically also have inputs and outputs added, however cmake has incremental builds already and these tasks are only run when running jtreg and take little time compared to the test suite.
>> 
>> I made a few minor style changes and fixed the comment on the jtreg task.
>> 
>> I would like feedback on one change, which is making the assemble task automatically run the jextractapp task to build a jextract binary. Do you think it is best if the assemble task automatically runs the verify task as well? Or should things just be left as they are and require running verify or jextractapp manually? For some brief insight into Gradle lifecycle tasks for those not familiar: The build task should build and test everything so it depends on assemble and check. The assemble task is responsible for building everything, it depends on jar in a default configuration. The check task is responsible for running tests. For more information see the Gradle docs [2].
>> 
>> [1] - https://mail.openjdk.java.net/pipermail/panama-dev/2022-March/016665.html
>> [2] - https://docs.gradle.org/current/userguide/base_plugin.html#sec:base_tasks
>
> build.gradle line 172:
> 
>> 170: }
>> 171: 
>> 172: // run jtreg tests. Note: needs jtreg_home variable set to point to the jtreg
> 
> good catch :) That comment is relic of the past.

I am not a committer in this project. So, we've to wait for @mcimadamore for sponsoring the change anyway. I'd like him to review and sponsor. Thanks for your contribution @danieljarabek !

-------------

PR: https://git.openjdk.java.net/jextract/pull/25