RFR: Layout updates

Athijegannathan Sundararajan sundar at openjdk.org
Mon Aug 29 08:59:17 UTC 2022


On Mon, 29 Aug 2022 08:31:27 GMT, Per Minborg <duke at openjdk.org> wrote:

> This PR updates jextract to work with the recent changes in Panama.

src/main/java/org/openjdk/jextract/impl/Utils.java line 322:

> 320:     }
> 321: 
> 322:     static String layoutClassNameInDeclaration(MemoryLayout layout) {

Could add a comment here on an internal class and public API interface class?

src/main/java/org/openjdk/jextract/impl/Utils.java line 323:

> 321: 
> 322:     static String layoutClassNameInDeclaration(MemoryLayout layout) {
> 323:         if (layout.getClass().getName().contains(".internal")) {

Could the check be based on interface vs class itself rather than ".internal" in package name of internal class?

-------------

PR: https://git.openjdk.org/jextract/pull/62


More information about the jextract-dev mailing list