RFR: 7903271: Add sample of libzstd [v3]
Mike Duigou
mduigou at openjdk.org
Tue Aug 30 17:23:34 UTC 2022
On Tue, 30 Aug 2022 13:49:24 GMT, Per Minborg <duke at openjdk.org> wrote:
>> This PR adds a sample using `libzstd`, a high-performance compression library.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright year
samples/libzstd/README line 1:
> 1: * Install libffmpeg on Mac using homebrew
This refers to libffmpeg rather than zstd.
samples/libzstd/README line 1:
> 1: * Install libffmpeg on Mac using homebrew
You could also suggest installing with system package manager (yum, apt, …)
samples/libzstd/compile.sh line 2:
> 1: jextract -t libzstd \
> 2: -I /usr/local/Cellar/zstd/1.5.2/include \
Consider replacing the path `/usr/local/Cellar/zstd/1.5.2` with `$(brew --prefix zstd)` or `$(pkg-config --variable=prefix libzstd)`
samples/libzstd/compile.sh line 5:
> 3: -l zstd \
> 4: --header-class-name Libzstd \
> 5: /usr/local/Cellar/zstd/1.5.2/include/zstd.h
Same comment about using non-static prefix path.
samples/libzstd/compilesource.sh line 2:
> 1: jextract --source -t libzstd \
> 2: -I /usr/local/Cellar/zstd/1.5.2/include \
Same comments for zstd prefix path.
-------------
PR: https://git.openjdk.org/jextract/pull/66
More information about the jextract-dev
mailing list