RFR: 7903121: initial jextract tool code, tests and samples
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Mar 21 17:36:54 UTC 2022
On Thu, 17 Mar 2022 02:16:06 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
> Adding initial standalone jextract code, tests and samples.
Looks good. I've tested the build on linux-x64 and it works ok. I've added some minor comments to make things a bit more consistent.
README.md line 157:
> 155:
> 156:
> 157: #### Building jextract tool
You probably want just `###` in these sections (for uniformity)
README.md line 172:
> 170: ```sh
> 171:
> 172: $ sh ./gradlew -Pjdk18_home=<jdk18_home_dir> -PLIBCLANG_HOME=<libclang_dir> clean verify
I think the clang property should be lowercase, for consistency with other properties
README.md line 172:
> 170: ```sh
> 171:
> 172: $ sh ./gradlew -Pjdk18_home=<jdk18_home_dir> -PLIBCLANG_HOME=<libclang_dir> clean verify
I think the clang property should be lowercase, for consistency with other properties
README.md line 191:
> 189: ### jextract samples
> 190:
> 191: jextract samples can be found "samples" top-level directory. Building/running particular sample may require
This should probably go somewhere more toplevel - e.g. in the first intro - but I'll do another pass on the document after you push.
README.md line 191:
> 189: ### jextract samples
> 190:
> 191: jextract samples can be found "samples" top-level directory. Building/running particular sample may require
This should probably go somewhere more toplevel - e.g. in the first intro - but I'll do another pass on the document after you push.
-------------
PR: https://git.openjdk.java.net/jextract/pull/2
More information about the jextract-dev
mailing list