RFR: Update Readme with macOs specifics [v2]
Brice Dutheil
duke at openjdk.java.net
Tue Mar 29 11:01:10 UTC 2022
On Tue, 29 Mar 2022 10:31:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix review comments
>
> README.md line 28:
>
>> 26: </details>
>> 27:
>> 28: After building, there should be a new `jextract` folder under `build` (the contents and the name of this folder might vary slightly depending on the platform, e.g. on macOs the folder is `jextract.app`) :
>
> Do you think it is still necessary to provide specific details about macOs here (and below) ?
Yes I think this is necessary as long as this is packaged with `jpackage`, because not everyone is accustomed ta macOs application layout.
In my opinion jpackage does a very neat job to pack desktop application. But for command line interactions this is less practical in my opinion. I think this might complicate a bit the consumption of this command line tool, requiring to adapt the actual path, that unless a workaround is set up (a symbolic link, or adding `.../jextract.app/Contents/MacOS` to `PATH`).
Ultimately I think a `.tar.gz` distribution would be better for consumption, but I don't know to do that (and elegantly) at this time.
-------------
PR: https://git.openjdk.java.net/jextract/pull/10
More information about the jextract-dev
mailing list