RFR: Update Readme with macOs specifics [v3]
Jorn Vernee
jvernee at openjdk.java.net
Tue Mar 29 13:04:21 UTC 2022
On Tue, 29 Mar 2022 11:16:45 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:
>> The macOs libclang location as well as build output differ enough to warrant specific information. In particular the use of the XCode based path to find the libclang is not an easy find. The output also makes use of jpackage with `app-image` type, but the macOs _.app_ layout different enough on macOs.
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>
> Make local installation quoted
One minor typo. Otherwise this looks good to me.
README.md line 18:
> 16: > <details><summary><strong>Using a local installation of LLVM</strong></summary>
> 17: >
> 18: > While the recommanded way is to use a [release from the LLVM project](https://releases.llvm.org/download.html),
Small typo here
Suggestion:
> While the recommended way is to use a [release from the LLVM project](https://releases.llvm.org/download.html),
-------------
Marked as reviewed by jvernee (no project role).
PR: https://git.openjdk.java.net/jextract/pull/10
More information about the jextract-dev
mailing list