RFR: gradle buildscript improvements
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu May 5 16:42:40 UTC 2022
On Wed, 27 Apr 2022 09:35:00 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> I guess I understand both concerns: on one hand, what @sundararajana says it's true: our tests do not fit in the gradle workflow nicely, as they can only be run after an integration step (e.g. the build of the image used to run jextract).
>>
>> That said, I also get the spirit of the changes here: we're asking developers to say "verify" when in reality what they'd like to be able to say is probably "build". So, if we just s/verify/build and keep "jtreg" as an optional task, what would go wrong?
>
> "jtreg" target requires additional toolset (cmake, C compiler, jtreg) at the user end. This is not the usual pure Java project "tests" which don't need any of these. Already "verify" doesn't depend on "jtreg" (verify is just build of jextract image + a simple integration test to extract a test.h). "jtreg" perhaps can skip the "project jextract image" + "integration test" step. i.e., after jar straight build test JDK image with jextract and run all jextract tests. But, not sure how much is saved by that.
I've tried out this patch, and I confirm that it behaves as described (e.g. second stacking). I had an offline discussion with @sundararajana who is also ok with this change. This can go ahead IMHO. I will approve.
-------------
PR: https://git.openjdk.java.net/jextract/pull/25
More information about the jextract-dev
mailing list