RFR: 7903344: refactor OutputFactory to introduce various Declaration Visitor classes [v2]

[Athijegannathan Sundararajan]

On Tue, 4 Oct 2022 12:08:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   moved getAsSignedOrUnsigned to Utils. Using Utils function isStructOrUnion instead of enum check.
>
> samples/libffmpeg/compile.sh line 3:
> 
>> 1: jextract -t libffmpeg \
>> 2:   -I /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include \
>> 3:   -I /usr/local/Cellar/ffmpeg at 4/4.4.2_4/include \
> 
> Are these changes deliberate?

Yes. Recent home-brew update brought this specific version on my machine. I need this for testing samples.

> src/main/java/org/openjdk/jextract/impl/NameMangler.java line 43:
> 
>> 41:  * java safe names via lookup methods.
>> 42:  *
>> 43:  * NOTE: Unlike other transforming tree visitors, this one is just identify
> 
> Can't we drop the TreeTransformer implementation?

Removed TreeTransformed implementation for NameMangler.

-------------

PR: https://git.openjdk.org/jextract/pull/81