RFR: 7903347: add long name option for all single letter options and expand help on default values for various options [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Oct 7 13:00:33 UTC 2022


On Fri, 7 Oct 2022 12:35:53 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * long option names for -I, -l, -D (--include-dir, --library, --define-macro)
>> * documented default values for header class name, target package and output directory
>> * explanation for -l / --library option.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   consistent double quote in help and README.md ('foo.h' -> "foo.h")

Added minor nit/suggestion

README.md line 140:

> 138: | `--header-class-name <name>`                                 | name of the generated header class. If this option is not specified, then header class name is derived from the header file name. For example, class "foo_h" for header "foo.h". |
> 139: | `-t, --target-package <package>`                             | target package name for the generated classes. If this option is not specified, then unnamed package is used.  |
> 140: | `-I, --include-dir <dir>`                                    | add directory to the end of the list of include search paths |

Suggestion:

| `-I, --include-dir <dir>`                                    | append directory to the include search paths. Include search paths are searched in order. For example, if `-I foo -I bar` is specified, header files will be searched in "foo" first, then (if nothing is found) in "bar".|

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.org/jextract/pull/83


More information about the jextract-dev mailing list