RFR: 7903257: jextract should generate javadoc comments [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Oct 12 12:21:35 UTC 2022


On Wed, 12 Oct 2022 12:12:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   defensive code to avoid possible crashes in doc generation
>
> src/main/java/org/openjdk/jextract/impl/CDeclarationPrinter.java line 162:
> 
>> 160:     // in the result.
>> 161: 
>> 162:     private static String nameAndType(Type type, String name) {
> 
> Maybe we should call this "varDecl" since this is morally to be used for variable declarations.

It's also not super clear to me what happens when the type has a name, and the user also specified a name. Can that ever happen? Or, if this happens, both names should be the same (in which case we should assert that).

-------------

PR: https://git.openjdk.org/jextract/pull/85


More information about the jextract-dev mailing list