RFR: 7903257: jextract should generate javadoc comments [v6]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Oct 13 12:43:22 UTC 2022


On Wed, 12 Oct 2022 17:21:27 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Generating C signature as doc comments.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added {@snippet : } around code in javadoc comment.

Looks good

src/main/java/org/openjdk/jextract/impl/StructBuilder.java line 56:

> 54:     private final Deque<String> prefixElementNames;
> 55: 
> 56:     StructBuilder(JavaSourceBuilder enclosing, Declaration.Scoped structTree,

Should this class override `addVar` so that doc comments for getters and setters are also generated (like in the case of global vars) ?

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.org/jextract/pull/85


More information about the jextract-dev mailing list