RFR: 7903257: jextract should generate javadoc comments [v6]
Athijegannathan Sundararajan
sundar at openjdk.org
Thu Oct 13 13:28:29 UTC 2022
On Thu, 13 Oct 2022 12:56:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added {@snippet : } around code in javadoc comment.
>
> src/main/java/org/openjdk/jextract/impl/CDeclarationPrinter.java line 224:
>
>> 222: // defensive. If no name is present, we don't want to crash
>> 223: return new TypeVisitorResult(false,
>> 224: t.name().isPresent()? t.name().get() : t.toString());
>
> Suggestion:
>
> return new TypeVisitorResult(false, t.name().orElse(t.toString()));
oops. missed your comments. Will piggyback in a later change.
-------------
PR: https://git.openjdk.org/jextract/pull/85
More information about the jextract-dev
mailing list