RFR: 7903357: add a jextract sample that uses pcre2 library [v2]

Athijegannathan Sundararajan sundar at openjdk.org
Fri Oct 14 16:34:15 UTC 2022


On Fri, 14 Oct 2022 16:12:04 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> samples/pcre2/Pcre.h line 32:
> 
>> 30:  */
>> 31: 
>> 32: #define PCRE2_CODE_UNIT_WIDTH 8
> 
> Couldn't this be done with `-DPCRE2_CODE_UNIT_WIDTH=8` as well?

yes, can be simplified. will do.

> samples/pcre2/PcreCheck.java line 63:
> 
>> 61:         System.err.printf("regex compilation failed: %s\n",
>> 62:             buffer.getUtf8String(0));
>> 63:         pcre2_code_free_8(re);
> 
> Does this free do anything? `re` seems to be `NULL` here.

will fix

-------------

PR: https://git.openjdk.org/jextract/pull/88


More information about the jextract-dev mailing list