RFR: Add Dockerfile, zero-dep reproducible builds
Gavin Ray
duke at openjdk.org
Thu Oct 27 13:45:45 UTC 2022
On Wed, 21 Sep 2022 13:55:19 GMT, Gavin Ray <duke at openjdk.org> wrote:
> As title says, adds a Dockerfile that will fetch all necessary deps and build `jextract` for you on Ubuntu 22.10
>
> It would be nice if some official JDK organization could put this on their Dockerhub, so that users could just do:
>
>
> $ docker run --rm -it openjdk/jextract:latest
>
>
> I've pushed it to my personal Dockerhub, so if anyone would like to test it out, you can use the README directions but prepend `gavinray/` before the image name:
>
>
> $ echo "struct Foo { int a; long b; }; int use_foo(struct Foo foo);" >> sample.h
>
> $ docker run --rm -it -v ${PWD}:/tmp/jextract \
> gavinray/jextract:latest \
> -I /tmp/jextract \
> --source \
> -l libfoo \
> --output /tmp/jextract/generated \
> --target-package com.example \
That's fair enough, maybe I could redo the PR where instead of putting the
Dockerfile in the repo,
an example definition that users can use for their own Dockerfiles if they
wish to build jextract
is provided in the documentation?
The problem I was hoping to solve is preventing users from needing to
manually install and
configure things like the right version of the LLVM toolchain for their OS,
etc
Would this be an acceptable compromise? Or is something like this still
better off in third-party land?
On Thu, Oct 27, 2022 at 6:45 AM Jorn Vernee ***@***.***>
wrote:
> Hi @GavinRay97 <https://github.com/GavinRay97> sorry for the late reply.
>
> After some internal discussions, we have decided not to take on this
> patch, or any other that adds a docker file.
>
> A docker file pulls in several dependencies from the internet, which have
> to be individually vetted and approved on a per-version basis.
>
> As we already do this for the gradle build, we are wary of adding more
> process overhead by adding a docker file (or other things that pull in more
> dependencies) to the repo as well. Besides that, it's another build
> configuration to maintain, and we already have 2 (gradle and make).
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jextract/pull/74#issuecomment-1293337834>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGK7LQWDOV2ZWNR4ISKBSB3WFJMLHANCNFSM6AAAAAAQSDEKYE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
-------------
PR: https://git.openjdk.org/jextract/pull/74
More information about the jextract-dev
mailing list