RFR: 7903597: Slim down RuntimeHelper [v3]

Jorn Vernee jvernee at openjdk.org
Mon Dec 4 14:56:18 UTC 2023


On Mon, 4 Dec 2023 14:40:27 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   drop unused method
>
> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 64:
> 
>> 62: 
>> 63:     ClassSourceBuilder(SourceFileBuilder builder, String modifiers, Kind kind, String className, String superName,
>> 64:                        ClassSourceBuilder enclosing, String runtimeHelperName) {
> 
> nit: maybe we want to call this "mainHeaderClass" or something like that?

I had `firstHeaderName` at first, but I didn't like how that name doesn't signal what the purpose of the field is, and the type `String` doesn't tell us much either. So, I switched it to `runtimeHelperName` (there might be a better name). If we ever decide to change the location of the helper methods again, the name would still work, since the purpose stays the same.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/150#discussion_r1414017833


More information about the jextract-dev mailing list