RFR: 7903606: Move layout and function descriptor generation closer to code builders [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Dec 11 19:40:08 UTC 2023


On Mon, 11 Dec 2023 19:13:50 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Not sure here - this function is meant to follow pointers until a function type is found. This method seems to do that?
>
> I was under the impression that this should only find function types for these 2 cases:
> 
> 
>    void (*cb)(void)
>    void cb(void)
> 
> 
> In which case we want to generate a functional interface. The old code also doesn't seem to follow typedefs for instance, but the new code does. This seems like a behavior change.

Yes, it's a behavior change, but when I wrote the new code, it seemed to me that the old behavior was missing certain cases where we wanted to generate a functional interface accessor?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/156#discussion_r1423034435


More information about the jextract-dev mailing list