RFR: 7903606: Move layout and function descriptor generation closer to code builders [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Dec 11 21:44:55 UTC 2023


On Mon, 11 Dec 2023 21:39:20 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> I mean, we don't use a reference to a layout constant we generated elsewhere, but always generate the layout string inline
>
> still don't get it :-) The `layout` variable is a local variable in this method?

Ok, I guess you meant this as an observation: since it's a primitive layout, we just emit JAVA_XYZ inline. This is different from what we do for offset (and size). If you prefer to add a layout constant too, I can add (for readability).

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/156#discussion_r1423157225


More information about the jextract-dev mailing list