Integrated: 7903606: Move layout and function descriptor generation closer to code builders
Maurizio Cimadamore
mcimadamore at openjdk.org
Tue Dec 12 10:32:49 UTC 2023
On Mon, 11 Dec 2023 14:31:49 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This PR moves calls to Type/Declaration.layoutFor/descriptorFor as close as possible to the leaf code builders. The reason for this change is to prepare the jextract code to generate layouts and descrptor strings directly from jextract types, so that we can retain as much information from the original clang cursor/types as possible when generating layouts.
>
> In order to get there, I had to add a lot of type predicates in the Utils class (perhaps some of these methods can be moved later directly in TypeImpl).
>
> And, perhaps the biggest change, is that previously we used layout presence/absence in `UnsupportedFilter` to make decision as to whether skip a certain declaration. For this reason, `UnsupportedFilter` (esp. its type visitor) has been enhanced to detect cases where layout generation would fail, but in a way that does not require us to generate layouts just to answer a question of "is this type supported?".
This pull request has now been integrated.
Changeset: b93d2b41
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/jextract/commit/b93d2b41b246423b76e38039a75cb5e54b370afd
Stats: 544 lines in 16 files changed: 190 ins; 173 del; 181 mod
7903606: Move layout and function descriptor generation closer to code builders
Reviewed-by: jvernee
-------------
PR: https://git.openjdk.org/jextract/pull/156
More information about the jextract-dev
mailing list