RFR: Remove dead code [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Dec 13 10:31:10 UTC 2023
On Wed, 13 Dec 2023 01:38:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - last few bits
>> - remove more dead code
>
> src/main/java/org/openjdk/jextract/impl/TreeMaker.java line 326:
>
>> 324: public Declaration.Scoped createEnum(Cursor c) {
>> 325: List<Declaration> decls = new ArrayList<>();
>> 326: c.forEach(child -> decls.add(createTree(child)));
>
> Not sure how we ended up with the current code, but an enum can not contain any bitfields AFAIK.
I think the code was filtering members in the same way when creating a new scoped (struct/union/enum). It seems like some code got inlined here, but yes, not too sure what bitfields have got to do with enums.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/158#discussion_r1425154409
More information about the jextract-dev
mailing list