RFR: 7903612: Nested struct typedefs fail to compile [v3]

Jorn Vernee jvernee at openjdk.org
Fri Dec 15 11:23:09 UTC 2023


On Fri, 15 Dec 2023 10:57:24 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR fixes a small issue with nested struct typedef, and another with typedef in general:
>> 
>> * nested struct classes are emitted with the `final` modifier, which prevents them from being subclassed (e.g. in typedefs)
>> * all structs have a private constructor to prevent clients from instantiating. Unfortunately this constructor also prevents subclassing (e.g. in typedef).
>> 
>> This patch drops the `final` modifier on nested struct/unions, and also tweaks the default constructor from `private` to `protected`.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Marked as reviewed by jvernee (Committer).

-------------

PR Review: https://git.openjdk.org/jextract/pull/164#pullrequestreview-1783637424


More information about the jextract-dev mailing list