RFR: 7903485 Windows.h fails to extract on jextract/panama

[Maurizio Cimadamore]

On Mon, 12 Jun 2023 09:42:10 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/main/java/org/openjdk/jextract/impl/TypeImpl.java line 376:
>> 
>>> 374:         try {
>>> 375:             return Optional.of(getLayoutInternal(t));
>>> 376:         } catch (Throwable ex) {
>> 
>> This seems to be reverting the changes from: https://github.com/openjdk/jextract/pull/121/files#r1210157420
>> 
>> Not sure if that's intended?
>
> I found other cases where the created layout was problematic and this fix was causing other jextract crashes. I think if we want to do this change we need better investigation of the implications, so I've reverted it for now.

I did another test, just to be sure, and now this seems no longer necessary. I believe the main fix was the changes related to the timing when function descriptors were created - e.g. now if a function contains unsupported layouts we no longer attempt to get a descriptor for it. Before this PR we did, and that caused the function descriptor factory to fail (as unsupported layouts end up with padding).

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/122#discussion_r1226487526