RFR: 7903590: Refactor jextract source code generation [v2]

[Jorn Vernee]

On Mon, 27 Nov 2023 12:00:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'panama' into Untangle
>>  - Review comments
>>  - don't emit constructor for first header + inline FIB modifiers
>>  - remove extra changes
>>  - add newSourceFile factory method
>>  - use isNested() predicate
>>  - fix header comment indentation
>>  - reduce inheritance
>>  - SourceFileBuilder
>
> src/main/java/org/openjdk/jextract/impl/JavaSourceBuilder.java line 38:
> 
>> 36: import java.util.Optional;
>> 37: 
>> 38: interface JavaSourceBuilder {
> 
> I suggest to rename that to something like OutputHelper, OutputBuilder or something like that - or even nest this interface inside OutputFactory, to make it clear that the two are related (e.g. OutputFactory.Builder).

Moved it to an inner `OuputFactory.Builder` interface

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/141#discussion_r1406120511