RFR: 7903590: Refactor jextract source code generation [v2]

[Jorn Vernee]

On Mon, 27 Nov 2023 13:26:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'panama' into Untangle
>>  - Review comments
>>  - don't emit constructor for first header + inline FIB modifiers
>>  - remove extra changes
>>  - add newSourceFile factory method
>>  - use isNested() predicate
>>  - fix header comment indentation
>>  - reduce inheritance
>>  - SourceFileBuilder
>
> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 63:
> 
>> 61:         this.className = className;
>> 62:         this.superName = superName;
>> 63:         this.enclosing = enclosing;
> 
> should we check that the enclosing class has the same source file builder as this one?

Note really important from the `ClassSourceBuilder` perspective. Having builders with different underlying `SourceFileBuilders` would still work AFAICS, the sources would just be emitted to different source files.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/141#discussion_r1406199002