RFR: 7903595: Leverage String templates [v2]

Mon Nov 27 22:46:11 UTC 2023

On Mon, 27 Nov 2023 22:06:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Do we need build changes to enable preview?

The build already passes `--enable-preview`. I don't think we changed this after the FFM API was finalized.

> src/main/java/org/openjdk/jextract/impl/Constants.java line 431:
> 
>> 429:         private Constant emitConstantString(Object value) {
>> 430:             NamedConstant segConstant = new NamedConstant(MemorySegment.class);
>> 431:             appendIndentedLines(STR."""
> 
> the `emitLayoutString` method could use a similar treatment - at least for some aspects?

I've sprinkled some more use of interpolation.

-------------

PR Comment: https://git.openjdk.org/jextract/pull/144#issuecomment-1828750076
PR Review Comment: https://git.openjdk.org/jextract/pull/144#discussion_r1406858402