RFR: 7903586: Revisit jextract constant classes [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Nov 29 12:08:02 UTC 2023


On Wed, 29 Nov 2023 11:42:51 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More doc alignment fixes
>
> src/main/java/org/openjdk/jextract/impl/HeaderFileBuilder.java line 238:
> 
>> 236:         incrAlign();
>> 237:         appendLines(STR."""
>> 238:             private static final MemorySegment \{mangledName} = RuntimeHelper.lookupGlobalVariable(\"\{nativeName}\", \{layoutString(0, layout)});
> 
> Shouldn't this re-use the layout field we emit instead of emitting the same layout string again inline?

good point

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/145#discussion_r1409183957


More information about the jextract-dev mailing list