Integrated: 7903697: jextract doesn't use name in asm label attribute
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Apr 10 11:27:10 UTC 2024
On Tue, 9 Apr 2024 17:53:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This PR restores a functionality that was available in a (much) older version of jextract.
>
> Basically, some library symbols can have a C name that differs from the symbol found in the shared library. This is typically done using an attribute (AsmLabelAttr). We already have code to parse declaration attributes, but when we switched to the new FFM-based jextract, we didn't update code generation to use the aliased name for the symbol lookup, if one was available.
>
> I've resurrected the old test to check this functionality, with some changes: the original test also tested Windows support, but that seems less important, given that Windows doesn't really have an equivalent feature/attribute.
This pull request has now been integrated.
Changeset: 1283561c
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/jextract/commit/1283561c5c85b3ff28203891262047d3de451cd5
Stats: 204 lines in 5 files changed: 199 ins; 0 del; 5 mod
7903697: jextract doesn't use name in asm label attribute
Reviewed-by: jvernee
-------------
PR: https://git.openjdk.org/jextract/pull/232
More information about the jextract-dev
mailing list