RFR: Use compiler switch to filter out `__asm` statements on Windows
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Apr 10 17:28:13 UTC 2024
On Wed, 10 Apr 2024 17:14:39 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> A newly added test uses `__asm` statements which are not supported by MSVC. I failed to catch this during the review of that patch, and this result in a compilation failure on Windows in the most recent version of the code.
>
> The test that needs this native code doesn't run on Windows any way, so I've removed all the Windows-isms from the native code, and instead just disabled compilation of the problematic code on Windows using a compiler switch.
>
> Alternatively, we could modify the `CMakeLists.txt` file to disable building this particular library on Windows, if that's preferred.
Thanks for checking. Question: why didn't the GHA tests failed?
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jextract/pull/234#pullrequestreview-1992306089
More information about the jextract-dev
mailing list