Integrated: Use compiler switch to filter out `__asm` statements on Windows
Jorn Vernee
jvernee at openjdk.org
Wed Apr 10 17:56:09 UTC 2024
On Wed, 10 Apr 2024 17:14:39 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> A newly added test uses `__asm` statements which are not supported by MSVC. I failed to catch this during the review of that patch, and this result in a compilation failure on Windows in the most recent version of the code.
>
> The test that needs this native code doesn't run on Windows any way, so I've removed all the Windows-isms from the native code, and instead just disabled compilation of the problematic code on Windows using a compiler switch.
>
> Alternatively, we could modify the `CMakeLists.txt` file to disable building this particular library on Windows, if that's preferred.
This pull request has now been integrated.
Changeset: c7994e77
Author: Jorn Vernee <jvernee at openjdk.org>
URL: https://git.openjdk.org/jextract/commit/c7994e779535d61a4bd5a123269c3618f0794178
Stats: 15 lines in 2 files changed: 2 ins; 4 del; 9 mod
Use compiler switch to filter out `__asm` statements on Windows
Reviewed-by: mcimadamore
-------------
PR: https://git.openjdk.org/jextract/pull/234
More information about the jextract-dev
mailing list