RFR: Add guide section about array types [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Tue Apr 16 17:04:10 UTC 2024
On Tue, 16 Apr 2024 16:45:25 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> The current guide is missing a section discussing the special handling of array types, for which jextract generates a `$dimensions()` accessor, and indexed getters and setters.
>>
>> This PR adds a section to the guide discussing this. I've put it at the end of the "Using The Code Generated By Jextract" section. I've put it before the section on nested types though, since it's a little more important I think.
>
> Jorn Vernee has updated the pull request incrementally with three additional commits since the last revision:
>
> - review comments
> - Update doc/GUIDE.md
>
> Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
> - Update doc/GUIDE.md
>
> Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
doc/GUIDE.md line 619:
> 617: // mylib.h
> 618:
> 619: int FOO_ARRAY[3][5];
Looking over the entire document, this is the only case where we use all caps. The other section on global variable uses lower case, so probably better to stick with that?
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/236#discussion_r1567689659
More information about the jextract-dev
mailing list