RFR: 7903788: preparation towards json configuration for jextract tool

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Aug 16 13:25:01 UTC 2024


On Fri, 16 Aug 2024 11:49:29 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> * adding json skara code into org.openjdk.jextract.json.parser package. Minor changes done - pretty printing, JSONValue is made sealed and access changes (private final fields).
> * org.openjdk.jextract.json package for JSON interface to the rest of the jextract tool. Main interface is org.openjdk.jextract.json.JSON. parse and toString methods to convert record into JSON String and vice versa.
> * Other classes are public mainly for testing purposes. build.gradle adjusted with the required --add-exports clauses so that jextract module does not have to export the new json packages.

src/main/java/org/openjdk/jextract/json/JSONObjects.java line 392:

> 390: 
> 391:     // get the Record component value as a JSONValue
> 392:     private static JSONValue getRecordProperty(Record record, RecordComponent rc) {

getRecordComponentValue seems a better name here?

src/main/java/org/openjdk/jextract/json/JSONObjects.java line 418:

> 416:     }
> 417: 
> 418:     private static Map<?,?> convertToMap(JSONObject jo, Type keyType, Type valueType) {

This seems overly general - isn't a JSON object always a map from String to something else?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/257#discussion_r1719829657
PR Review Comment: https://git.openjdk.org/jextract/pull/257#discussion_r1719831833


More information about the jextract-dev mailing list