RFR: 7903788: preparation towards json configuration for jextract tool [v4]
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Aug 16 14:32:02 UTC 2024
On Fri, 16 Aug 2024 14:06:18 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> * adding json skara code into org.openjdk.jextract.json.parser package. Minor changes done - pretty printing, JSONValue is made sealed and access changes (private final fields).
>> * org.openjdk.jextract.json package for JSON interface to the rest of the jextract tool. Main interface is org.openjdk.jextract.json.JSON. parse and toString methods to convert record into JSON String and vice versa.
>> * Other classes are public mainly for testing purposes. build.gradle adjusted with the required --add-exports clauses so that jextract module does not have to export the new json packages.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with two additional commits since the last revision:
>
> - removed WildcardType (review suggestion)
> - renamed JSONObjects.getRecordProperty to be getRecordComponentValue. (review suggestion)
The parser addition and tests look ok.
I'm not overall convinced on the need for the mapper classes, and I think we should proceed w/o it for now, and see how bad it is.
-------------
Changes requested by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jextract/pull/257#pullrequestreview-2242850081
More information about the jextract-dev
mailing list