RFR: 7903788: preparation towards json configuration for jextract tool [v5]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Aug 16 15:03:34 UTC 2024


On Fri, 16 Aug 2024 15:00:55 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * adding json skara code into org.openjdk.jextract.json.parser package. Minor changes done - pretty printing, JSONValue is made sealed and access changes (private final fields).
>> * org.openjdk.jextract.json package for JSON interface to the rest of the jextract tool. Main interface is org.openjdk.jextract.json.JSON. parse and toString methods to convert record into JSON String and vice versa.
>> * Other classes are public mainly for testing purposes. build.gradle adjusted with the required --add-exports clauses so that jextract module does not have to export the new json packages.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - missed one more -Xlint:unchecked. removed unused --add-exports for mapper package which has been removed.
>  - got rid of mappers (per review suggestion)

Looks good (pending build changes)

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jextract/pull/257#pullrequestreview-2242917186


More information about the jextract-dev mailing list