RFR: 7903731: Jextract should support macOS frameworks [v2]
Marcono1234
duke at openjdk.org
Tue Dec 31 13:32:49 UTC 2024
On Tue, 31 Dec 2024 12:24:25 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Read the JBS issue for more detail.
>>
>> This patch adds two new mac specific options, to make it easier to use frameworks and remove the need of a `compile_flags.txt` file. An exception is thrown if those options are used from an other platform, the error message is inspired from `jpackage`
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typos, rename some methods and bump copyright year to 2025
src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties line 94:
> 92: --mac-framework-dir <dir> specify the framework directory \n\
> 93: -f <framework> specify framework library. -f libGL is equivalent to \n\
> 94: \ -l :/System/Library/Frameworks/libGL.framework/libGL \n
Wrong / inconsistent indentation?
Suggestion:
-f <framework> specify framework library. -f libGL is equivalent to \n\
\ -l :/System/Library/Frameworks/libGL.framework/libGL \n
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1900114511
More information about the jextract-dev
mailing list