RFR: 7903660: Drop layout-inferring varargs invoker + add method handle factory [v3]

[Jorn Vernee]

On Mon, 12 Feb 2024 16:44:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use invoker class
>
> src/main/java/org/openjdk/jextract/impl/HeaderFileBuilder.java line 221:
> 
>> 219: 
>> 220:                     /**
>> 221:                      * {@return specialized method handle}
> 
> Should we use an article here? E.g."the specialized" - not sure how it would look in the javadoc

This looks like:


Returns specialized method handle.


So yeah, "the" is missing

> test/jtreg/generator/testPrintf/TestPrintf.java line 54:
> 
>> 52: 
>> 53:     @Test(dataProvider = "cases")
>> 54:     public void testsPrintfHandle(String fmt, Object[] args, String expected, MemoryLayout[] layouts) throws Throwable {
> 
> Shouldn't we also have a test for the invoker interface?

We have an existing one (below this one)

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/205#discussion_r1486488760
PR Review Comment: https://git.openjdk.org/jextract/pull/205#discussion_r1486487010