RFR: 7903672: Some issues with missing dependency errors

[Maurizio Cimadamore]

On Sat, 17 Feb 2024 16:39:53 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> - Only error on missing dependencies, if the dependent is not skipped
> - Scan element types of arrays for missing dependencies as well
> - Don't issue warnings about unsupported types/fields for skipped elements
> 
> I've pulled the code that issues errors for missing dependencies into a separate phase (`MissingDepWarner`), since the control flow in some of the visitor methods was kinda tricky to follow if this stayed mixed in with the `IncludeFilter` code. The new phase just cleanly checks whether the visited element has a `Skip` on it and then returns at the start, before doing any work.
> 
> I've also re-ordered the phases a bit so that the phases that add Skips run first, so that we don't issue warnings/errors for things that are skipped any way by a later phase. Since `UnsupportedFilter` both adds Skips and issues warnings, it sits right in the middle.
> 
> Q: should we also return early in `NameMangler` if an element is skipped? (Right now it's just doing extra work).

Marked as reviewed by mcimadamore (Reviewer).

-------------

PR Review: https://git.openjdk.org/jextract/pull/217#pullrequestreview-1888699406