RFR: 7903674: jextract should ignore non-enum constants inside enum [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Feb 20 10:38:03 UTC 2024


On Tue, 20 Feb 2024 07:41:11 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * checking cursor kind of child cursor to be CursorKind.EnumConstantDecl. 
>> * Piggybacking to fix similar check of record child element kinds to be CursorKind.FieldDecl.  
>> * Added null check for createTree return value in collectNestedTypes method as well.
>> * In addition to jextract tests, I ran all samples on Mac OS. All fine with this change. Also, ran jextract script for Mac OS from  https://github.com/manuelbl/JavaDoesUSB.git.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved nested 'if' inside 'else' as 'else if'

Is there some kind of tests we can add for the new logic? I guess I'm still struggling to understand what kind of cursor kind can cause this havoc - the C grammar doesn't seem to support much beside enum constants inside an enum?

-------------

PR Comment: https://git.openjdk.org/jextract/pull/221#issuecomment-1953923991


More information about the jextract-dev mailing list