RFR: 7903674: jextract should ignore non-enum constants inside enum [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Feb 20 14:02:06 UTC 2024


On Tue, 20 Feb 2024 13:43:32 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reduce the diffs for this patch.
>
> src/main/java/org/openjdk/jextract/impl/TreeMaker.java line 374:
> 
>> 372:                 if (child.kind() == CursorKind.EnumConstantDecl) {
>> 373:                     Declaration enumConstantDecl = createTree(child);
>> 374:                     if (enumConstantDecl != null) {
> 
> The null check here is not needed anymore. (test coverage shows the `null` branch is uncovered here as well)

Isn't that the whole point of the fix? (e.g. skipping nulls when a "weird" cursor shows up)

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/221#discussion_r1495870301


More information about the jextract-dev mailing list