RFR: 7903615: Jextract should generate javadoc contents using libclang pretty printer [v3]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Jan 10 14:56:54 UTC 2024
On Wed, 10 Jan 2024 13:11:11 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix issue with comments in macro values
>
> src/main/java/org/openjdk/jextract/impl/TreeMaker.java line 483:
>
>> 481: cursorString = declarationString(cursor, true);
>> 482: }
>> 483: yield cursorString;
>
> So, if I understand directly, this is different from what is described in the PR body. e.g. we will try to expand struct types as just `struct Foo`, unless we also find anonymous decls, in which case we expand to `struct Foo { int x; int y; }` ?
yes, this change was described in a follow up comment
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/169#discussion_r1447496698
More information about the jextract-dev
mailing list