RFR: 7903630: jextract emits duplicate symbols for macro clashing with enum constants [v2]
Athijegannathan Sundararajan
sundar at openjdk.org
Tue Jan 16 12:09:00 UTC 2024
On Tue, 16 Jan 2024 12:06:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> The removal of `EnumConstantLifter` caused certain name conflicts to go undetected by `DuplicateFilter`. More specifically, if a macro constant has same name as that of an enum constant, given the enum constant is no longer lifted to toplevel, `DuplicateFilter` will not see the clash. The fix is to tweak `DuplicateFilter` to recurse into enums.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>
> Add extra test case
LGTM
-------------
Marked as reviewed by sundar (Committer).
PR Review: https://git.openjdk.org/jextract/pull/177#pullrequestreview-1823177061
More information about the jextract-dev
mailing list