RFR: 7903631: Improve names for getter/setters

Jorn Vernee jvernee at openjdk.org
Tue Jan 16 15:33:53 UTC 2024


On Tue, 16 Jan 2024 15:15:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch improves the parameter names for getter/setter methods generated inside a struct.
> 
> As I was writing this I realized that:
> 
> * we were not using `safeParameterName` consistently. So I've sprinkled that to cover all generated methods;
> * we were not generating a setter for fields whose type was a by-value struct. A new setter is now added (which uses `MemorySegment::copy`). A test has also been added.

Marked as reviewed by jvernee (Committer).

-------------

PR Review: https://git.openjdk.org/jextract/pull/179#pullrequestreview-1823792549


More information about the jextract-dev mailing list