RFR: 7903633: Make source mode the default, and drop compiled mode [v2]

Jorn Vernee jvernee at openjdk.org
Fri Jan 19 11:59:53 UTC 2024


On Fri, 19 Jan 2024 10:40:13 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify Writer + Remove JavaFileObject dependency
>
> test/jtreg/generator/clinitCycles/TestGlobal.java line 32:
> 
>> 30: 
>> 31: /*
>> 32:  * @test id
> 
> note that `id` is the name that is given to the test run, which is then visible in the output (e.g. so that we could separate between issues in `sources` and `classes`). If there's only one run, the `id` is no longer needed, I think

Right, `id` should be dropped too

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/186#discussion_r1458887099


More information about the jextract-dev mailing list