RFR: 7903633: Make source mode the default, and drop compiled mode [v2]

[Jorn Vernee]

On Fri, 19 Jan 2024 10:27:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify Writer + Remove JavaFileObject dependency
>
> src/main/java/org/openjdk/jextract/impl/Writer.java line 29:
> 
>> 27: package org.openjdk.jextract.impl;
>> 28: 
>> 29: import org.openjdk.jextract.JavaSourceFile;
> 
> Do we really need a class for this? Seems more like an helper method to the main jextract tool?

You mean remove `Writer`? Or `JavaSourceFile`?

> test/lib/testlib/TestUtils.java line 74:
> 
>> 72:             commands.add("-parameters");
>> 73:             commands.add("--source=22");
>> 74:             commands.add("--enable-preview");
> 
> I don't think the preview flag should be required? (since the API is now final)

Right, I thought maybe we needed it for string templates, but we don't generate those.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/186#discussion_r1458925553
PR Review Comment: https://git.openjdk.org/jextract/pull/186#discussion_r1458926415