RFR: Make method handle accessor private
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Jan 19 22:04:55 UTC 2024
On Fri, 19 Jan 2024 21:15:35 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> My comment got dropped it seems.
>
> What do you think about `MEMBER_MODS`? This is not something that is variable WRT the template text. I think I'd personally rather see the expanded code in the template, so that it's easier to see what is being generated.
>
> Though, theoretically, this makes it harder to bulk update all the access modifiers. But, that seems pretty rare any way?
>
> P.S. and, in this case I don't think the variable name `MEMBER_MODS` adds any clarity to the code.
I agree, will replace.
-------------
PR Comment: https://git.openjdk.org/jextract/pull/188#issuecomment-1901179270
More information about the jextract-dev
mailing list