RFR: Make method handle accessor private [v2]

Jorn Vernee jvernee at openjdk.org
Fri Jan 19 22:39:57 UTC 2024


On Fri, 19 Jan 2024 22:14:13 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> In my previous PR, I forgot to also make the method handle accessor (for native downcalls) `private`.
>> 
>> This was discovered when manually eyeballing at jextracted code for windows.h.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Marked as reviewed by jvernee (Committer).

src/main/java/org/openjdk/jextract/impl/HeaderFileBuilder.java line 164:

> 162:                 emitDocComment(decl);
> 163:                 appendLines(STR."""
> 164:                 \{"public static"} \{retType} \{javaName}(\{paramExprs(declType, finalParamNames, isVarArg)}) {

I suppose this should just be:

Suggestion:

                public static {retType} {javaName}({paramExprs(declType, finalParamNames, isVarArg)}) {

-------------

PR Review: https://git.openjdk.org/jextract/pull/188#pullrequestreview-1833875502
PR Review Comment: https://git.openjdk.org/jextract/pull/188#discussion_r1459915961


More information about the jextract-dev mailing list