Integrated: 7903637: Use holder classes for string constants

Jorn Vernee jvernee at openjdk.org
Mon Jan 22 19:51:01 UTC 2024


On Mon, 22 Jan 2024 18:35:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Use holder class idiom for string constants (See JBS issue for motivation).
> 
> The code in `emitConstant` is a bit copy-pasty. We need to strike a balance between giving a clear picture of the generated code by using a single string template as much as possible, and reducing duplication by splitting the templates up and weaving in more control flow.
> 
> I went with the repeated, but clearer approach here of having 2 separate templates. Let me know if you'd like me to change that.

This pull request has now been integrated.

Changeset: 13a783fd
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.org/jextract/commit/13a783fdd6a6228e8143f2038ceb659545bbc9c0
Stats:     30 lines in 1 file changed: 15 ins; 2 del; 13 mod

7903637: Use holder classes for string constants

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jextract/pull/191


More information about the jextract-dev mailing list