RFR: 7903779: unify logger messages to show position whenever possible

Jorn Vernee jvernee at openjdk.org
Thu Jul 25 12:51:43 UTC 2024


On Thu, 25 Jul 2024 12:28:51 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> * logger.warn/.err/.info Position accepting overloads.
> * Error message format is: <position>:"fatal"|"error"|"warning"|"info"|:<message> (consistent with clang).
> * ClangException has position, severity and spelling. ClangExceptions are printed using logger.print.

src/main/java/org/openjdk/jextract/impl/Parser.java line 115:

> 113:     }
> 114: 
> 115:     record PositionRecord(Path path, int line, int col) implements Position {}

If you want, you could make this record local to the `asPosition` method I think

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/254#discussion_r1691386493


More information about the jextract-dev mailing list