RFR: 7903727: Remove the reliance on String Templates feature [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Jun 4 09:22:36 UTC 2024


On Sat, 1 Jun 2024 18:46:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> This PR aims to replace the usage of string templates with `String::format`, since there will be no string template feature in JDK 23.
>> I tried to keep similar indentation and convert them in-place, to make reviewing the changes easier.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added number references to arguments

src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 110:

> 108:             extendsExpr = " extends " + superName;
> 109:         }
> 110:         appendLines("%s %s %s%s {", modifiers, kind.kindName, className, extendsExpr);

no numbers here?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1625663906


More information about the jextract-dev mailing list