RFR: 7903727: Remove the reliance on String Templates feature [v5]

[Jorn Vernee]

On Tue, 4 Jun 2024 13:08:46 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Overall, it seems to me that we need to decide on a policy on when to use numbering, as the current patch seems inconsistent. I see three options:
> 
>     1. don't use numbering
> 
>     2. only use numbering when there are repeated occurrences of same format argument
> 
>     3. use numbering everywhere
> 
> 
> I think (1) is where we started from. The current patch seems to be a mix between (2) and (3). In general, (2) might be enough, as it avoids repetition on very long format calls, while not making readability of simple cases overly complex. But I'm also ok with (3) if we prefer keeping same style for all calls.

I think it makes sense to use numbering for repeated values as well as longer snippets (more than 1-2 lines). Probably for consistency it's better to use numbers everywhere then

-------------

PR Comment: https://git.openjdk.org/jextract/pull/244#issuecomment-2148064596